Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multi-CSI-camera with libcamera #1068

Merged
merged 10 commits into from
Dec 25, 2023

Conversation

BytingBulldogs3539
Copy link
Contributor

Adjusts JNI for multicamera changes. Also rewrites VisionSourceManager for multicamera changes and QOL changes. Also fixes issue #1028.

@BytingBulldogs3539 BytingBulldogs3539 requested a review from a team as a code owner December 24, 2023 04:20
@BytingBulldogs3539
Copy link
Contributor Author

BytingBulldogs3539 commented Dec 24, 2023

PrePrevCapture
PrevCapture1
Post
Capture

RPI 5 with 4gb of ram

@mcm001
Copy link
Contributor

mcm001 commented Dec 24, 2023

Some of those other metrics look a bit sus to me -- idk about you

@SeanErn
Copy link

SeanErn commented Dec 24, 2023

image
I get a 0fps metric with Apriltag mode even though the stream is still running at around 25fps Weirdly, all the other pipeline types work fine...

@BytingBulldogs3539
Copy link
Contributor Author

Some of those other metrics look a bit sus to me -- idk about you

Other than the temp matrix everything else is fine. The RPI 5 should report 4mb for GPU memory (https://forums.raspberrypi.com/viewtopic.php?t=358327). Occasionally I get an unknown value but a refresh does fix it. Additionally, this was with 3 cameras all running non driver mode pipelines so I would expect the cpu to be pegged.

Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi-cam works on pi 5 anyways, shipiiiitiiiij;dasfj;lkdfasjk;

@mcm001 mcm001 changed the title Multi CSI Camera Changes, Also fixes Issue #1028 Update libcamera to enable multi-CSI-cameras Dec 25, 2023
@mcm001 mcm001 changed the title Update libcamera to enable multi-CSI-cameras Enable multi-CSI-camera with libcamera Dec 25, 2023
@mcm001 mcm001 merged commit 0b98f02 into PhotonVision:master Dec 25, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants